assert: don't serialize assert.snapshot input#44443
Closed
MoLow wants to merge 2 commits intonodejs:mainfrom
Closed
assert: don't serialize assert.snapshot input#44443MoLow wants to merge 2 commits intonodejs:mainfrom
assert.snapshot input#44443MoLow wants to merge 2 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
assert
anonrig
reviewed
Aug 29, 2022
| } | ||
|
|
||
| function serializeName(name) { | ||
| validateString(name, 'name'); |
Member
There was a problem hiding this comment.
Quick question: Is there a specific reason to remove this validation in here?
Member
|
cc #44466 |
tniessen
requested changes
Aug 31, 2022
Member
tniessen
left a comment
tniessen
left a comment
There was a problem hiding this comment.
This again does not come close to correctness.
At a quick glance at the implementation, I am pretty sure these will fail:
await snapshot('x\n#*#*#*#*#*#*#*#*#*#*#*#\nb:\ny', 'foo');await snapshot('a:\r\nb', 'bar');
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up from #44429
waiting for #44429 to land so documentation will be adjusted as well